Release process cleanups post 25.09 #8534
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rustyrussell
commented
Sep 4, 2025
rustyrussell
commented
- Build inside docker should be parallel.
- Don't assume sudo to run docker commands (use --sudo if you need it).
- Various documentation cleanups and fixes.
- Always append version to SHA256SUMS file.
On GitHub where we build the zipfile, it exists, so we don't check out the submodule. If you do, your zipfile won't match! Signed-off-by: Rusty Russell <[email protected]>
…ic PR merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Build: release builds with tools/build-release.sh are deterministic again.
Defaults to nproc, but you can set MAKEPAR=N to override it. Timings on my laptop are only a little better, because Rust. Before: time tools/build-release.sh bin-Fedora bin-Ubuntu ... real 33m17.104s user 0m4.259s sys 0m3.605s After: time tools/build-release.sh bin-Fedora bin-Ubuntu ... real 25m25.556s user 0m4.297s sys 0m3.743s Signed-off-by: Rusty Russell <[email protected]>
I don't! Signed-off-by: Rusty Russell <[email protected]>
We found a bug last release, and had to yoink tag back from GH. This is not good! Signed-off-by: Rusty Russell <[email protected]>
`--without-zip sign` will not work. You will end up with a empty SHA256SUMS file. Signed-off-by: Rusty Russell <[email protected]>
1. Put v prefix before NEW_VERSION 2. Change the checkin line to a one-liner. 3. Have build-release.sh check for the v prefix (with --force-version= you could omit it). Signed-off-by: Rusty Russell <[email protected]>
Telling users to rename it is a poor idea, and if you have multiple releases in your release/ dir it will get confusing. So always append -v25.09 and update docs accordingly. Signed-off-by: Rusty Russell <[email protected]>
With more developers, inevitably there are PRs queued during the release process. Just accept that there will need to be a branch created for any point release. Signed-off-by: Rusty Russell <[email protected]>
Whitespace changes only. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/lightning-release-process-cleanup
branch
from
6c9b6a5 to
64cb8c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.